Add Codable conformance and human-readable names to EncryptionCipher#21
Merged
Add Codable conformance and human-readable names to EncryptionCipher#21
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the EncryptionCipher struct by adding Codable conformance for JSON serialization and introducing human-readable display names for UI contexts. The version is also updated from 0.1.8 to 0.1.9 to reflect these changes.
Key changes:
- Added Codable conformance to EncryptionCipher for serialization support
- Implemented humanReadableName property with user-friendly cipher names
- Updated version number to 0.1.9
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/SwiftKeyGenCLI/main.swift | Version number updated to 0.1.9 |
| Sources/SwiftKeyGen/Formats/OpenSSH/OpenSSHPrivateKey.swift | Enhanced EncryptionCipher with Codable conformance and human-readable names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the EncryptionCipher struct with Codable conformance for easier serialization and add human-readable names for better display in UI contexts. Update the version to 0.1.9.